-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Make router and vuex proper packages #2335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm reluctant to add two new generator-only plugins. |
I think yes, because right now the generation is not very consistent and also having these as internal options in
I actually have no issue about this as an end-user if the cli-plugin-vuex has more helpful commands (like maybe generating a store module etc..) |
Yeah, definitely worth it if such features implemented. |
I will work on this and send a PR for the initial packages. Then we can discuss on the features to be implemented after that PR is merged. I am always up for a chat on discord if you need someone to brainstorm with. |
😀Cool, much appreciated. |
What problem does this feature solve?
There's a lot of careful manipulation being done in @vue/cli code because of the above plugins not being proper packages, which we could avoid. Since the implementation of #1202, the format of the above plugins is in a proper plugin format anyway. So, why don't we move them to their own packages in the repo? That way, we could remove all the specialty code written just for these packages.
What does the proposed API look like?
Have 2 new packages @vue/cli-plugin-router, @vue/cli-plugin-vuex
The text was updated successfully, but these errors were encountered: