[PWA] /img/icons cache?

[frizar]

Version

3.1.1

Reproduction link

https://test-app-8134f.firebaseapp.com/

Node and OS info

node 10.13.0, npm 6.4.1, macOS 10.14, windows 10

Steps to reproduce

Im new in PWA plugin, so i have a question. Is "/img/icons" folder not cached by service worker by default and why?
I created new app with PWA option, deploy it to firebase and i see that any files from "/img/icons" not cached...
https://test-app-8134f.firebaseapp.com/ this is my result. Open dev console, enable Offline mode, reload page.
Screenshot: http://joxi.ru/52aR4oxSE4j1YA
Same problem with manifest.json. It is correct behavior?

What is expected?

Any files from public folder should be cached by default

What is actually happening?

/img/icons folder not cached, also manifest.json not cached

---

Please tell me if im wrong and explain me why this happens and how to fix(?) it.
Thanks! Sorry for my English, btw.

[haoqunjiang]

Because icons are excluded in the default workbox settings:

vue-cli/packages/@vue/cli-plugin-pwa/index.js

Lines 33 to 40 in cdec606

	const defaultOptions = {
	exclude: [
	/\.map$/,
	/img\/icons\//,
	/favicon\.ico$/,
	/manifest\.json$/
	]
	}

#769 (comment)

The request that a browser makes for either a registered favicon or for the home screen icon bypasses the service worker, so there's no benefit from caching them.

manifest.json was excluded as we followed workbox's default config. (They'll change the behavior in the upcoming v4, though. GoogleChrome/workbox#1679)

These default options can be overridden by configuring the pwa.workboxOptions field in vue.config.js. https://github.com/vuejs/vue-cli/tree/dev/packages/%40vue/cli-plugin-pwa#configuration

[frizar]

@sodatea oh, thank you very much! ❤️

[troncoso]

I'm looking into this exact issue, and while I understand the default configuration excludes these, it would be nice to know the correct way to ensure the home screen icon/favicon are properly cached so they can display in offline mode. Is there any insight on that? This issue is nearly a year and a half old, so maybe some things have changed?

[ninest]

@troncoso I believe you can check this in the chrome dev tools. Go to offline mode, and you'll see that the icons are still there.

The problem I'm facing though, is that the icons aren't getting updated. The browser is still using the same icons from the cache

[troncoso]

@ninest Yes, I see the icons there, but when running in offline mode, the browser tab stops showing the favicon.

[ninest]

@troncoso so for you, the PWA is working offline, but only the icons won't show?