Skip to content

Refine Override hardcoded arguments even further #3810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
katerlouis opened this issue Apr 14, 2019 · 1 comment
Closed

Refine Override hardcoded arguments even further #3810

katerlouis opened this issue Apr 14, 2019 · 1 comment

Comments

@katerlouis
Copy link
Contributor

katerlouis commented Apr 14, 2019

image

Originally posted by @Akryum in #3236 (comment)

I like the functionality.
The UI is not entirely clear on what's happening, though.

  1. When you change the mode with the override toggle disabled, users might still expect the mode to be overwritten. Maybe because they didn't realize vue-cli has changed in that regard. Or maybe because they don't understand what the override toggle is supposed to do? Or they didn't read it at all.

Suggestion: separate the override-toggle visually with an <hr /> and some more spacings and grey out the other settings. This way the user knows what's possible to change on first glimpse without forgetting these settings won't have any effects yet.

  1. In this modal decisions on build etc. are made, so I'd argue the script-string is needed here more than it is on site below. Having to close the modal just to check the script again is no fun.

Suggestion: add the script line to the modal aswell

image

For those who might think this is nitpicky:
The UI is more confusing here than to just use the command line. Since I think those already struggling with this whole webpack-es6-vue-cli will opt for the UI, which is why this should be as bullet proof as possible.

@vue-bot
Copy link

vue-bot commented Apr 14, 2019

Hello, your issue has been closed because it does not conform to our issue requirements. In order to ensure every issue provides the necessary information for us to investigate, we require the use of the Issue Helper when creating new issues. Thank you!

@vue-bot vue-bot closed this as completed Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants