improve tsx support
#1168
Merged
improve tsx support
#1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsn
reviewed
Apr 27, 2018
| } | ||
|
|
||
| declare global { | ||
| namespace JSX { |
There was a problem hiding this comment.
IMO, JSX declaration should be included in core lib’s declaration.
I remember @blake-newman was working on that?
There was a problem hiding this comment.
You are right, but it's not available right now.
Maybe we could use this until core lib's declaration released
There was a problem hiding this comment.
I am currently using this as a stop gap: https://github.com/wonderful-panda/vue-tsx-support (Some of the typing is wrong)
May be worth bringing some of this in, i think with some planning we should be able to get it all via types with no need for an API.
| @@ -3,7 +3,8 @@ | |||
| "target": "<%- options.useTsWithBabel ? 'esnext' : 'es5' %>", | |||
| "module": "esnext", | |||
| "strict": true, | |||
| "jsx": "preserve", | |||
| "jsx": "preserve", | |||
| "jsxFactory": "h", | |||
There was a problem hiding this comment.
Why do we need this? AFAIK, it only affects when jsx is set to react.
HerringtonDarkholme
approved these changes
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.