Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better local template handling with Windows compatability #194

Merged
merged 2 commits into from
Nov 2, 2016

Conversation

presidenten
Copy link

@presidenten presidenten commented Oct 12, 2016

Windows users have trouble using local templates when the the previous solution only checked for slash and not backslash or path.sep. With this new approach mac, linux and windows users can also use relative paths to the template:

   vue init ./myTemplate projectName

or

   vue init ../myTemplatesFolder/myTemplate projectName

Tested on Mac osx with node 6.2.2 both from local build and globally installed build, as well as Windows 8 with node 6.7.0 from local build.

@presidenten
Copy link
Author

Please wait with the merge, I broke the absolute path local init. Ill fix it and send a new pull request.

@presidenten
Copy link
Author

There we go!
Now it also works with absolute paths. Sorry for the trouble.

It has now been tested on mac, linux (ubuntu), and windows.

@zigomir zigomir self-assigned this Oct 28, 2016
@zigomir
Copy link
Contributor

zigomir commented Nov 2, 2016

Thanks for working on this @presidenten, looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants