Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli-service): add envs dir config #3135

Closed
wants to merge 3 commits into from
Closed

Conversation

jtommy
Copy link
Contributor

@jtommy jtommy commented Dec 14, 2018

@LinusBorg
Copy link
Member

LinusBorg commented Dec 15, 2018

This change means that env cars are no longer accessible in the vue.config.js file directly, since you load it before the vars are loaded.

Would have to be considered a breaking change imho

@jtommy
Copy link
Contributor Author

jtommy commented Dec 15, 2018

@LinusBorg Yes, I said to you in the issue link I had to change the location where envs are loaded.
To be honest I didn't find another config file, except vue.config.js, where to add this option.

@LinusBorg
Copy link
Member

LinusBorg commented Dec 15, 2018

To be honest I didn't find another config file, except vue.config.js, where to add this option.

Well, vue.config.js would be the right place in theory, and there's not other config file to use.

But since this change would mean you can't access process.en.VUE_APP_WHATEVER from your vue.config file anymore (except in functions like chainWebpack which are executed later), this would constitute a breaking change and we can't add it until we do 4.0, strictly speaking.

We can use #2506 to discuss other strategies, but right now I don't have any in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants