Fix import path for isPluginRequired and use correct built-ins #3673
Conversation
perkola
changed the title
|
I guess you'd also want to mention in package.json that this change requires |
Good catch! I was a bit too quick. I have updated the PR now. |
| const { isPluginRequired } = require('@babel/preset-env') | ||
| const builtInsList = require('@babel/preset-env/data/built-ins.json') | ||
| const { isPluginRequired } = require('@babel/preset-env/lib/filter-items') | ||
| const builtInsList = require('@babel/preset-env/data/corejs2-built-ins.json') |
There was a problem hiding this comment.
Hi, Babel maintainer here 👋
We just released v7.4.1, which should fix the issue. The builtInsList change is correct, but I'd ask you to revert line 17 (it's better not to rely on internal files, when possible). You'll need to update the preset-env version in package.json.
There was a problem hiding this comment.
Hi! Thank you for the quick reply. I noticed that you also aliased cosejs2 so both my changes are unnecessary right now. Perhaps we still need to change the path of built-ins.json if the alias is removed in the future.
|
This PR becomes obsolete with the release of |
|
Please update |
Relates to #3671