Escape double quotes in string prompts #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test case for this? |
|
I'm not home anymore, but I can do this tomorrow ;)
If I understood you correctly, the test should just verify that the
package.json is valid JSON?
Eduardo San Martin Morote <notifications@github.com> schrieb am Mi., 8.
März 2017, 12:06:
… Can you add a test case for this?
You can reuse one of the tests and verify that the generated package json
is correct by parsing it
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#388 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGmW1mhfIipGhuBJZ0PPNiHdfsHqKufrks5rjovQgaJpZM4MWozV>
.
|
|
Yes, so that the double quotes are escaped correctly |
|
Okay, I think that I should be able to do this :)
Eduardo San Martin Morote <notifications@github.com> schrieb am Mi., 8.
März 2017, 12:12:
… Yes, so that the double quotes are escaped correctly
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#388 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGmW1u7SGg_c2hPFkMA8uBfdErK3GtGbks5rjo0jgaJpZM4MWozV>
.
|
|
I just added a test to check the escaping. I tired to leave the other tests alone and add it seperately... May not be the best test, but it should do the trick 😄 |
posva
reviewed
Mar 9, 2017
test/e2e/test.js
Outdated
| const pkg = fs.readFileSync(`${MOCK_TEMPLATE_BUILD_PATH}/package.json`, 'utf8') | ||
| try { | ||
| var validData = JSON.parse(pkg) | ||
| expect(validData.author).to.equal(escapedAuthor) |
There was a problem hiding this comment.
Can't you just do expect(validData.author).to.equal(escapedAnswers.author) ?
There was a problem hiding this comment.
Jup, could definitively do that.... My mistake 😂
There was a problem hiding this comment.
Just woke up an hour ago, still not very awake
posva
approved these changes
Mar 9, 2017
|
LGTM 👍 |
This was referenced Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #382.
It checks if the answer type is
string, and if it is,replaces"with\", so it can be parsed as valid JSON.