-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
feat(typescript): add an option to not rename all .js files to .ts and to set allowJs
to true
#4212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
84e6e63
fix: fixed TS plugin to ask for renaming files
NataliaTepluhina c62e6fa
fix: refactored renaming main file
NataliaTepluhina 5181ee8
fix: set convert js to ts flag to true by default
NataliaTepluhina 74ce7b1
fix: added tsLint check to main.js renaming
NataliaTepluhina c2e1fc6
fix: merged options
NataliaTepluhina File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,33 @@ | ||
module.exports = (api, { tsLint = false } = {}) => { | ||
// delete all js files that have a ts file of the same name | ||
// and simply rename other js files to ts | ||
module.exports = (api, { tsLint = false, convertAllFiles = true } = {}) => { | ||
const jsRE = /\.js$/ | ||
const excludeRE = /^tests\/e2e\/|(\.config|rc)\.js$/ | ||
const convertLintFlags = require('../lib/convertLintFlags') | ||
api.postProcessFiles(files => { | ||
for (const file in files) { | ||
if (jsRE.test(file) && !excludeRE.test(file)) { | ||
const tsFile = file.replace(jsRE, '.ts') | ||
if (!files[tsFile]) { | ||
let content = files[file] | ||
if (tsLint) { | ||
content = convertLintFlags(content) | ||
if (convertAllFiles) { | ||
// delete all js files that have a ts file of the same name | ||
// and simply rename other js files to ts | ||
for (const file in files) { | ||
if (jsRE.test(file) && !excludeRE.test(file)) { | ||
const tsFile = file.replace(jsRE, '.ts') | ||
if (!files[tsFile]) { | ||
let content = files[file] | ||
if (tsLint) { | ||
content = convertLintFlags(content) | ||
} | ||
files[tsFile] = content | ||
} | ||
files[tsFile] = content | ||
delete files[file] | ||
} | ||
delete files[file] | ||
} | ||
} else { | ||
// rename only main file to main.ts | ||
const tsFile = api.entryFile.replace(jsRE, '.ts') | ||
let content = files[api.entryFile] | ||
if (tsLint) { | ||
content = convertLintFlags(content) | ||
} | ||
files[tsFile] = content | ||
delete files[api.entryFile] | ||
} | ||
}) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.