Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vue add should be able to install prerelease versions for official plugins #4356

Merged
merged 2 commits into from
Jul 29, 2019
Merged

fix: vue add should be able to install prerelease versions for official plugins #4356

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5849b15
fix: `vue add` should install prerelease versions for official plugins
haoqunjiang Jul 25, 2019
b63345a
fix: use ^${cliVersion} instead of next tag
haoqunjiang Jul 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/@vue/cli/lib/add.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
const chalk = require('chalk')
const semver = require('semver')
const invoke = require('./invoke')

const PackageManager = require('./util/ProjectPackageManager')
const {
log,
error,
resolvePluginId
resolvePluginId,
isOfficialPlugin
} = require('@vue/cli-shared-utils')
const confirmIfGitDirty = require('./util/confirmIfGitDirty')

Expand All @@ -21,7 +23,13 @@ async function add (pluginName, options = {}, context = process.cwd()) {
log()

const pm = new PackageManager({ context })
await pm.add(packageName)

const cliVersion = require('../package.json').version
if (isOfficialPlugin(packageName) && semver.prerelease(cliVersion)) {
await pm.add(`${packageName}@^${cliVersion}`)
} else {
await pm.add(packageName)
}

log(`${chalk.green('✔')} Successfully installed plugin: ${chalk.cyan(packageName)}`)
log()
Expand Down