Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli-service): word spelling in comments #4367

Merged
merged 1 commit into from
Jul 28, 2019
Merged

chore(cli-service): word spelling in comments #4367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@vue/cli-service/lib/commands/serve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ module.exports = (api, options) => {
validateWebpackConfig(webpackConfig, api, options)

// load user devServer options with higher priority than devServer
// in webpck config
// in webpack config
const projectDevServerOptions = Object.assign(
webpackConfig.devServer || {},
options.devServer
Expand Down Expand Up @@ -129,7 +129,7 @@ module.exports = (api, options) => {
// explicitly configured via devServer.public
? `?${publicUrl}/sockjs-node`
: isInContainer
// can't infer public netowrk url if inside a container...
// can't infer public network url if inside a container...
// use client-side inference (note this would break with non-root publicPath)
? ``
// otherwise infer the url
Expand Down
2 changes: 1 addition & 1 deletion packages/@vue/cli/lib/GeneratorAPI.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ function renderFile (name, data, ejsOptions) {
)

// use ejs.render to test the conditional expression
// if evaluated to falsy vaule, return early to avoid extra cost for extend expression
// if evaluated to falsy value, return early to avoid extra cost for extend expression
const result = ejs.render(finalTemplate, data, ejsOptions)
if (!result) {
return
Expand Down
2 changes: 1 addition & 1 deletion packages/@vue/cli/lib/upgrade.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ class Upgrader {
}

async checkForUpdates () {
logWithSpinner('Gathering pacakage information...')
logWithSpinner('Gathering package information...')
const upgradable = await this.getUpgradable()
stopSpinner()

Expand Down