Skip to content

fix: do not install core plugins that have major version bumps #4720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2019
Merged

fix: do not install core plugins that have major version bumps #4720

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95a0477
fix: fix version check for core plugins in v4
haoqunjiang Oct 19, 2019
db9869b
fix: fix the error when the diff result is null
haoqunjiang Oct 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/@vue/cli/lib/Creator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,13 @@ module.exports = class Creator extends EventEmitter {
const { current, latest } = await getVersions()
let latestMinor = `${semver.major(latest)}.${semver.minor(latest)}.0`

// if using `next` branch of cli
if (semver.gte(current, latest) && semver.prerelease(current)) {
if (
// if the latest version contains breaking changes
/major/.test(semver.diff(current, latest)) ||
// or if using `next` branch of cli
(semver.gte(current, latest) && semver.prerelease(current))
) {
// fallback to the current cli version number
latestMinor = current
}
// generate package.json with plugin dependencies
Expand Down