-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
make vue.config.js async, this will let pull param #4954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Guys, please do not omit this request ;) |
This PR breaks all test groups. It doesn't update any tests or add new tests for this feature. We cannot merge this PR like this - a lot of work is missing. |
Hi,
Any other idea how to add some data to project via vue.config.js when data needs to be pulled from database??
Any hints will be appreciated.
Regards,
Marek
|
@gocmarek |
Hi,
Thanks for advice, I already applied some kind of solution like
that.Anyway it would be very helpful to have possibility to inject
something before the app started and for this I wanted to have merged
this what I proposed.
Regards,Marek
-------- Wiadomość oryginalna ----------Od: simon3000 <
notifications@github.com>Odpowiedź do: vuejs/vue-cli <
reply@reply.github.com>Do:
vuejs/vue-cli <vue-cli@noreply.github.com>Kopia: Marek <
goc_marek@ma-al.com>, Author <author@noreply.github.com>Temat: Re:
[vuejs/vue-cli] make vue.config.js async, this will let pull param
(#4954)Data: Thu, 19 Mar 2020 14:03:37 -0700
One solution might be, to write a different script which save the
result on some temporary file; execute this script with something like
child_process.execSync, and use readFileSync to read the result in
vue.config.js
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Well, this proposal doesn't work. I'll close this PR since it's not mergable in this form. If we wanted to support an async config, we would have to probnably do an RFC about it and evaluate the impact this would have in various places. |
OK, clear for me.But think about it...
Anyway, thanks a lot for all effort to make this nice piece ... Vue and
all around.
…-------- Wiadomość oryginalna ----------Od: Thorsten Lünborg <
notifications@github.com>Odpowiedź do: vuejs/vue-cli <
reply@reply.github.com>Do:
vuejs/vue-cli <vue-cli@noreply.github.com>Kopia: Marek <
goc_marek@ma-al.com>, Mention <mention@noreply.github.com>Temat: Re:
[vuejs/vue-cli] make vue.config.js async, this will let pull param
(#4954)Data: Fri, 20 Mar 2020 03:00:09 -0700
Well, this proposal doesn't work. I'll close this PR since it's not
mergable in this form.
If we wanted to support an async config, we would have to probnably do
an RFC about it and evaluate the impact this would have in various
places.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
Please add this little change to your incredible job, it will make possibility to pull some data from external source to vue.config.js. In my case this will help a lot and I think not only for me.
I think this should not bring any security degradation or something like that.