Skip to content

make vue.config.js async, this will let pull param #4954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gocmarek
Copy link

@gocmarek gocmarek commented Dec 12, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:
Please add this little change to your incredible job, it will make possibility to pull some data from external source to vue.config.js. In my case this will help a lot and I think not only for me.

I think this should not bring any security degradation or something like that.

@gocmarek
Copy link
Author

Guys, please do not omit this request ;)

@LinusBorg
Copy link
Member

This PR breaks all test groups. It doesn't update any tests or add new tests for this feature. We cannot merge this PR like this - a lot of work is missing.

@gocmarek
Copy link
Author

gocmarek commented Dec 13, 2019 via email

@simon300000
Copy link
Contributor

simon300000 commented Mar 19, 2020

Hi, Any other idea how to add some data to project via vue.config.js when data needs to be pulled from database?? Any hints will be appreciated. Regards, Marek

@gocmarek
One solution might be, to write a different script which save the result on some temporary file; execute this script with something like child_process.execSync, and use readFileSync to read the result in vue.config.js

@gocmarek
Copy link
Author

gocmarek commented Mar 20, 2020 via email

@LinusBorg
Copy link
Member

Well, this proposal doesn't work. I'll close this PR since it's not mergable in this form.

If we wanted to support an async config, we would have to probnably do an RFC about it and evaluate the impact this would have in various places.

@LinusBorg LinusBorg closed this Mar 20, 2020
@gocmarek
Copy link
Author

gocmarek commented Mar 20, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants