fix pwa installability when using noopServiceWorker "Page does not work offline" #5327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orker currently google chrome prevents installing pwa due to the error: “Page does not work offline”. The reason is service worker has to listen to fetch event. It doesnt have to do anything so the listener can be an empty function, but it has to be declared
haoqunjiang
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Other information:
Hi,
currently Google Chrome prevents installing local pwa due to the error: "Page does not work offline". The reason is service worker has to listen to
fetchevent. Since in localhost we servenoopServiceWorkerwe should not cache any requests thus fetch listener should be an empty function.The reason why i think this change is important is, pwa technologies are quite complex and there are already lots of debugging involved, so being able to quickly see (+) install icon in google chrome will prevent early giving up on pwa by new comers.
Unfortunately I couldnt find docs explaining why
fetchlistener is needed, the solution is taken from this stackoverflow answer. I did check that emptyfetchlistener doesnt have any side effects besides installability, as implementing any form of request interception is done viaevent.respondWith[1] [2]