Skip to content

feat(cli): make globby includes dot files #5537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2020
Merged

Conversation

fxxjdedd
Copy link
Contributor

@fxxjdedd fxxjdedd commented May 29, 2020

https://cli.vuejs.org/zh/dev-guide/plugin-dev.html#generator

Although in this passage, it is suggested that we should change ".env" to "_env" to solve the problem of uploading npm packages. But there will also be such a demand, the files in generator/template are dynamically pulled from the git repository at runtime, and there may be .env files in the repository, so this pr can solve the problem here

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

https://cli.vuejs.org/zh/dev-guide/plugin-dev.html#generator
Although in this passage, it is suggested that we should change ".env" to "_env" to solve the problem of uploading npm packages. But there will also be such a demand, the files in `generator/template` are dynamically pulled from the git repository at runtime, and there may be `.env` files in the repository, so this pr can solve the problem here
@haoqunjiang haoqunjiang merged commit 451f3d2 into vuejs:dev Dec 20, 2020
@fxxjdedd fxxjdedd deleted the patch-1 branch December 21, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants