-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add "devServer.server.type" to "useHttps" judgement #7222
Conversation
With this fix https for the application seems to work fine, however it fails to connect to HMR server: module.exports = defineConfig({
devServer: {
server: {
type: 'https',
options: {
key: fs.readFileSync('...'),
cert: fs.readFileSync('...'),
},
},
}, iirc the following config worked in vue cli 4/webpack 4 devServer: {
https: {
key: fs.readFileSync('...'),
cert: fs.readFileSync('...'),
},
}, |
Your case is similar to #7160, if |
Thanks @backrunner devServer: {
server: {
type: 'https',
options: {
key: fs.readFileSync('...'),
cert: fs.readFileSync('...'),
},
},
client: {
webSocketURL: 'auto://localhost:8081/ws',
},
allowedHosts: 'all',
}, |
|
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@vue/cli-plugin-babel](https://togithub.com/vuejs/vue-cli/tree/dev/packages/@vue/cli-plugin-babel#readme) ([source](https://togithub.com/vuejs/vue-cli)) | [`4.5.19` -> `5.0.8`](https://renovatebot.com/diffs/npm/@vue%2fcli-plugin-babel/4.5.19/5.0.8) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@vue%2fcli-plugin-babel/5.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@vue%2fcli-plugin-babel/5.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@vue%2fcli-plugin-babel/4.5.19/5.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@vue%2fcli-plugin-babel/4.5.19/5.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@vue/cli-plugin-eslint](https://togithub.com/vuejs/vue-cli/tree/dev/packages/@vue/cli-plugin-eslint#readme) ([source](https://togithub.com/vuejs/vue-cli)) | [`4.5.19` -> `5.0.8`](https://renovatebot.com/diffs/npm/@vue%2fcli-plugin-eslint/4.5.19/5.0.8) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@vue%2fcli-plugin-eslint/5.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@vue%2fcli-plugin-eslint/5.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@vue%2fcli-plugin-eslint/4.5.19/5.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@vue%2fcli-plugin-eslint/4.5.19/5.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@vue/cli-plugin-pwa](https://togithub.com/vuejs/vue-cli/tree/dev/packages/@vue/cli-plugin-pwa#readme) ([source](https://togithub.com/vuejs/vue-cli)) | [`4.5.19` -> `5.0.8`](https://renovatebot.com/diffs/npm/@vue%2fcli-plugin-pwa/4.5.19/5.0.8) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@vue%2fcli-plugin-pwa/5.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@vue%2fcli-plugin-pwa/5.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@vue%2fcli-plugin-pwa/4.5.19/5.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@vue%2fcli-plugin-pwa/4.5.19/5.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@vue/cli-service](https://cli.vuejs.org/) ([source](https://togithub.com/vuejs/vue-cli)) | [`4.5.19` -> `5.0.8`](https://renovatebot.com/diffs/npm/@vue%2fcli-service/4.5.19/5.0.8) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@vue%2fcli-service/5.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@vue%2fcli-service/5.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@vue%2fcli-service/4.5.19/5.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@vue%2fcli-service/4.5.19/5.0.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vuejs/vue-cli (@​vue/cli-plugin-babel)</summary> ### [`v5.0.8`](https://togithub.com/vuejs/vue-cli/releases/tag/v5.0.8) [Compare Source](https://togithub.com/vuejs/vue-cli/compare/v5.0.7...v5.0.8) ##### 🐛 Bug Fix - `@vue/cli-service` - [0260e4d](https://togithub.com/vuejs/vue-cli/commit/0260e4d) fix: add devServer.server.type to useHttps judgement ([https://github.com/vuejs/vue-cli/pull/7222](https://togithub.com/vuejs/vue-cli/pull/7222)) - `@vue/cli-ui` - [07052c4](https://togithub.com/vuejs/vue-cli/commit/07052c4) fix: Vue CLI UI graphql subscription server error, fixes [https://github.com/vuejs/vue-cli/issues/7221](https://togithub.com/vuejs/vue-cli/issues/7221) ### [`v5.0.7`](https://togithub.com/vuejs/vue-cli/blob/HEAD/CHANGELOG.md#507-2022-07-05) [Compare Source](https://togithub.com/vuejs/vue-cli/compare/v5.0.6...v5.0.7) - `@vue/cli-service` - [#​7202](https://togithub.com/vuejs/vue-cli/pull/7202), \[[558dea2](https://togithub.com/vuejs/vue-cli/commit/558dea2)] fix: support `devServer.server` option, avoid deprecation warnings ([@​backrunner](https://togithub.com/backrunner), [@​sodatea](https://togithub.com/sodatea)) - \[[beffe8a](https://togithub.com/vuejs/vue-cli/commit/beffe8a)] fix: allow disabling progress plugin via `devServer.client.progress` - `@vue/cli-ui` - [#​7210](https://togithub.com/vuejs/vue-cli/pull/7210) chore: upgrade to apollo-server-express 3.x ##### Committers: 2 - BackRunner ([@​backrunner](https://togithub.com/backrunner)) - Haoqun Jiang ([@​sodatea](https://togithub.com/sodatea)) ### [`v5.0.6`](https://togithub.com/vuejs/vue-cli/blob/HEAD/CHANGELOG.md#506-2022-06-16) [Compare Source](https://togithub.com/vuejs/vue-cli/compare/v5.0.5...v5.0.6) Fix compatibility with the upcoming Vue 2.7 (currently in alpha) and Vue Loader 15.10 (currently in beta). In Vue 2.7, `vue-template-compiler` is no longer a required peer dependency. Rather, there's a new export under the main package as `vue/compiler-sfc`. ### [`v5.0.5`](https://togithub.com/vuejs/vue-cli/blob/HEAD/CHANGELOG.md#505-2022-06-16) [Compare Source](https://togithub.com/vuejs/vue-cli/compare/v5.0.4...v5.0.5) ##### 🐛 Bug Fix - `@vue/cli` - [#​7167](https://togithub.com/vuejs/vue-cli/pull/7167) feat(upgrade): prevent changing the structure of package.json file during upgrade ([@​blzsaa](https://togithub.com/blzsaa)) - `@vue/cli-service` - [#​7023](https://togithub.com/vuejs/vue-cli/pull/7023) fix: windows vue.config.mjs support ([@​xiaoxiangmoe](https://togithub.com/xiaoxiangmoe)) ##### Committers: 3 - Martijn Jacobs ([@​maerteijn](https://togithub.com/maerteijn)) - ZHAO Jinxiang ([@​xiaoxiangmoe](https://togithub.com/xiaoxiangmoe)) - [@​blzsaa](https://togithub.com/blzsaa) ### [`v5.0.4`](https://togithub.com/vuejs/vue-cli/blob/HEAD/CHANGELOG.md#504-2022-03-22) [Compare Source](https://togithub.com/vuejs/vue-cli/compare/v5.0.3...v5.0.4) ##### 🐛 Bug Fix - `@vue/cli-service` - [#​7005](https://togithub.com/vuejs/vue-cli/pull/7005) Better handling of `publicPath: 'auto'` ([@​AndreiSoroka](https://togithub.com/AndreiSoroka)) - `@vue/cli-shared-utils`, `@vue/cli-ui` - [75826d6](https://togithub.com/vuejs/vue-cli/commit/75826d6) fix: replace `node-ipc` with `@achrinza/node-ipc` to further secure the dependency chain ##### Committers: 1 - Andrei ([@​AndreiSoroka](https://togithub.com/AndreiSoroka)) - Haoqun Jiang ([@​sodatea](https://togithub.com/sodatea)) ### [`v5.0.3`](https://togithub.com/vuejs/vue-cli/blob/HEAD/CHANGELOG.md#503-2022-03-15) [Compare Source](https://togithub.com/vuejs/vue-cli/compare/v5.0.2...v5.0.3) ##### 🐛 Bug Fix - `@vue/cli-shared-utils`, `@vue/cli-ui` - Lock `node-ipc` to v9.2.1 ### [`v5.0.2`](https://togithub.com/vuejs/vue-cli/blob/HEAD/CHANGELOG.md#502-2022-03-15) [Compare Source](https://togithub.com/vuejs/vue-cli/compare/v5.0.1...v5.0.2) ##### 🐛 Bug Fix - `@vue/cli-service` - [#​7044](https://togithub.com/vuejs/vue-cli/pull/7044) fix(cli-service): devServer proxy should be optional ([@​ntnyq](https://togithub.com/ntnyq)) - [#​7039](https://togithub.com/vuejs/vue-cli/pull/7039) chore: add scss to LoaderOptions ([@​hiblacker](https://togithub.com/hiblacker)) ##### Committers: 2 - Blacker ([@​hiblacker](https://togithub.com/hiblacker)) - ntnyq ([@​ntnyq](https://togithub.com/ntnyq)) ### [`v5.0.1`](https://togithub.com/vuejs/vue-cli/blob/HEAD/CHANGELOG.md#501-2022-02-17) [Compare Source](https://togithub.com/vuejs/vue-cli/compare/v5.0.0...v5.0.1) Same as 5.0.0. ### [`v5.0.0`](https://togithub.com/vuejs/vue-cli/blob/HEAD/CHANGELOG.md#500-2022-02-17) [Compare Source](https://togithub.com/vuejs/vue-cli/compare/v4.5.19...v5.0.0) ##### 🐛 Bug Fix - `@vue/cli-service` - [#​6972](https://togithub.com/vuejs/vue-cli/pull/6972) Remove --skip-plugin from arguments ([@​MatthijsBurgh](https://togithub.com/MatthijsBurgh)) - [#​6987](https://togithub.com/vuejs/vue-cli/pull/6987) fix: update mini-css-extract-plugin to ^2.5.3 ([@​darrinmn9](https://togithub.com/darrinmn9)) ##### 📝 Documentation - [#​6706](https://togithub.com/vuejs/vue-cli/pull/6706) docs: update vue create --help output in "Basics/Creating a Project" ([@​Lalaluka](https://togithub.com/Lalaluka)) - [#​6642](https://togithub.com/vuejs/vue-cli/pull/6642) docs: Update README.md ([@​wxsms](https://togithub.com/wxsms)) - [#​6620](https://togithub.com/vuejs/vue-cli/pull/6620) Fix typo in deployment guide ([@​Klikini](https://togithub.com/Klikini)) - [#​6623](https://togithub.com/vuejs/vue-cli/pull/6623) fix(docs): the plugin-dev in zh has a regexp lose the end / ([@​HelloJiya](https://togithub.com/HelloJiya)) - [#​6377](https://togithub.com/vuejs/vue-cli/pull/6377) replace master with main to reflect GH default ([@​anbnyc](https://togithub.com/anbnyc)) - [#​6359](https://togithub.com/vuejs/vue-cli/pull/6359) Fix master to main in heroku deployment ([@​MowlCoder](https://togithub.com/MowlCoder)) - [#​6266](https://togithub.com/vuejs/vue-cli/pull/6266) Add note about loader incompatible with webpack 4 ([@​JarnoRFB](https://togithub.com/JarnoRFB)) - [#​6239](https://togithub.com/vuejs/vue-cli/pull/6239) Update deployment.md ([@​anzuj](https://togithub.com/anzuj)) - [#​6237](https://togithub.com/vuejs/vue-cli/pull/6237) fix code demo ([@​yyzclyang](https://togithub.com/yyzclyang)) ##### Committers: 13 - Alec Barrett ([@​anbnyc](https://togithub.com/anbnyc)) - Alexander Sokolov ([@​Alex-Sokolov](https://togithub.com/Alex-Sokolov)) - Andy Castille ([@​Klikini](https://togithub.com/Klikini)) - Anzelika ([@​anzuj](https://togithub.com/anzuj)) - Ben Hutton ([@​Relequestual](https://togithub.com/Relequestual)) - Calvin Schröder ([@​Lalaluka](https://togithub.com/Lalaluka)) - Darrin Nagengast ([@​darrinmn9](https://togithub.com/darrinmn9)) - Matthijs van der Burgh ([@​MatthijsBurgh](https://togithub.com/MatthijsBurgh)) - Rüdiger Busche ([@​JarnoRFB](https://togithub.com/JarnoRFB)) - [@​HelloJiya](https://togithub.com/HelloJiya) - [@​MowlCoder](https://togithub.com/MowlCoder) - wxsm ([@​wxsms](https://togithub.com/wxsms)) - 鱼依藻常乐 ([@​yyzclyang](https://togithub.com/yyzclyang)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/chemicaltools/chemicaltools-web). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTQuOSIsInVwZGF0ZWRJblZlciI6IjM2LjguMTEiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
In the recent merged Pull Request #7202 which authored by me, the fixed judgement expression is not perfect, it should also consider the
devServer.server.type
because it can be anobject
.This patch add another judgement expression to cover this case, if user set
devServer.server.type
tohttps
orspdy
, theprotocol
will behttps
.