Add validation for package name in vue init #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@watilde it would be really nice if you can also provide a test case. |
watilde
force-pushed
the
feature/validate-package-name
branch
2 times, most recently
from
08b2b5c to
3bf614f
Compare
watilde
force-pushed
the
feature/validate-package-name
branch
from
3bf614f to
03e2bce
Compare
watilde
force-pushed
the
feature/validate-package-name
branch
from
03e2bce to
ea95f3d
Compare
|
@zigomir Thanks for your comment! I've rebased and added a test case. |
|
@watilde nice! Thanks for the update. This looks good to me. @yyx990803 do you agree as well? |
|
@yyx990803 @zigomir Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
I try to add a
validationto check package name is invalid or not invue init.