Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed update info's formatting. #835

Closed
wants to merge 1 commit into from
Closed

Fixed update info's formatting. #835

wants to merge 1 commit into from

Conversation

RatanShreshtha
Copy link

Before the prompt for new available update looked like this

┌─────────────────┐
│ ✨ Update available: 3.0.0-alpha.13 ✨ │
└─────────────────┘

After

┌──────────────────┐
│ ✨ Update available: 3.0.0-alpha.13 ✨ │
└──────────────────┘

Before the prompt for new available update looked like this

┌─────────────────┐
│ ✨  Update available: 3.0.0-alpha.13 ✨  │
└─────────────────┘

After 

┌──────────────────┐
│ ✨  Update available: 3.0.0-alpha.13 ✨  │
└──────────────────┘
@yyx990803
Copy link
Member

What OS / shell / terminal are you using? It looks fine in macOS/bash...

@RatanShreshtha
Copy link
Author

RatanShreshtha commented Feb 15, 2018

I am using tilix with fish on fedora 27.

@RatanShreshtha
Copy link
Author

Can anyone tell me how can I test this and make sure that it's not a shell / terminal issue.

@chrisvfritz
Copy link
Contributor

@RatanShreshtha Emoji can sometimes do strange things with length counts, such as:

'🙏🏻'.length //=> 4

In the above scenario, it's because the emoji is actually a ligature. I wonder if something similar is happening, like maybe isn't fully supported on the system so not included in the length? Total stab in the dark, but you could try '✨'.length to see what you get.

@yyx990803
Copy link
Member

yyx990803 commented Mar 1, 2018

Or we can just remove the emoji to avoid the headache ;) (If that turns out to be the culprit)

@RatanShreshtha
Copy link
Author

I have tried '✨'.length in node repel and its giving me 1 as the output.

@chrisvfritz
Copy link
Contributor

Hm, would you mind trying to remove the emoji locally anyway and seeing if that fixes it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants