Skip to content

Pwa improvement #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2017
Merged

Pwa improvement #194

merged 3 commits into from
May 30, 2017

Conversation

mhadaily
Copy link
Contributor

Hi @yyx990803,

I have fixed the issues below and we can get 100/100 again 💯

  1. Configured for a custom splash screen
  2. The page contains a heading, skip link, or landmark region.
  3. [user-scalable="no"] is not used in the element and the [maximum-scale] attribute is not less than 5.

Let me know if you need any other change, happy to help.

@yyx990803
Copy link
Member

Thanks - not sure where (2) and (3) are specified for PWA, as I didn't see them listed in Lighthouse results. Do you have a link?

@mhadaily
Copy link
Contributor Author

mhadaily commented May 30, 2017

They are actually related to Accessibility not PWA itself. I just uploaded here. But I think it's good to have as it boosts the score.

@yyx990803
Copy link
Member

Oh I see, they are down below.

@yyx990803 yyx990803 merged commit 253a3aa into vuejs:master May 30, 2017
@mhadaily mhadaily deleted the pwa-improvment branch May 30, 2017 08:29
@rdunk
Copy link

rdunk commented Jul 10, 2017

Although the skip link might improve the lighthouse score, in this case the link just points to the entire app wrapper element so as far as I can see actually provides no accessibility benefits by skipping navigation elements for example. I know this app isn't focused on meeting accessibility requirements but thought I'd point this out in case anyone else was wondering about the functionality of that element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants