Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert SourceMapGenerator to RawSourceMap #275

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

nogic1008
Copy link
Collaborator

Jest requires a map property of type RawSourceMap, but this package passes SourceMapGenerator.
I forgot to fix this in #255, excuse me.

fixes #241 and jestjs/jest#10089

@lmiller1990
Copy link
Member

Thanks. would is be difficult to port this to 5.0.0 (next branch?)

@lmiller1990 lmiller1990 merged commit 9f0e36e into vuejs:master Sep 10, 2020
@lmiller1990
Copy link
Member

Does this need to be released asap?

@nogic1008
Copy link
Collaborator Author

@lmiller1990
OK, I'll send a PR for next branch.

This PR fixes code coverage issue, so I want to be released soon.
But if you want to include other fix(es), I await this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest coverage reports cause an error with v4.0.0-beta.2
2 participants