fix: Revert vueOptionsNamespace changes from <script setup> commit #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a test so we don’t break it again? thanks! |
Signed-off-by: Wolfgang Walther <walther@technowledgy.de>
Signed-off-by: Wolfgang Walther <walther@technowledgy.de>
|
Added the custom-block test that was there for 3.x to 2.x as well. I confirmed that the test breaks before and passes after my fix. |
wolfgangwalther
commented
Sep 22, 2022
Comment on lines
-3
to
-4
| <span :class="this.$style.g"></span> | ||
| <span :class="this.$style.dark.f"></span> |
There was a problem hiding this comment.
Stumbled across this.. and removed it as well. No this in <template>!
|
Looks good! It's out: https://github.com/vuejs/vue-jest/releases/tag/v29.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #489 (comment), vue2-jest v29.1.0 broke custom block processors.
This PR just reverts a few changes of #489, which look unrelated to the PR and are entirely broken. There seemed to be a
componentNamespaceconfig option added - but this was documented nowhere and the default value for it was broken.