-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v15-beta fails when the vue-loader rule uses include
#1201
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
15.0.0-beta.2
Reproduction link
https://github.com/Loilo/vue-loader-15-include-repro
Steps to reproduce
Clone the repository and install npm dependencies:
Run webpack:
What is expected?
The
VueLoaderPlugin
should initialize correctly.What is actually happening?
The
VueLoaderPlugin
complains that "no matching rule for vue files are found".I've dug into the source and found the cause: The check if a loader is matching
foo.vue
returnsfalse
if the rule has aninclude
property. This is correct for webpack's own behaviour but probably undesirable forvue-loader
.A sufficient solution would probably be to (locally) remove the
include
property before normalizing rules.I'd be happy to attach a PR for this.I have attached a PR for this.The text was updated successfully, but these errors were encountered: