Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v15-beta fails when the vue-loader rule uses include #1201

Closed
loilo opened this issue Mar 23, 2018 · 0 comments
Closed

v15-beta fails when the vue-loader rule uses include #1201

loilo opened this issue Mar 23, 2018 · 0 comments

Comments

@loilo
Copy link

loilo commented Mar 23, 2018

Version

15.0.0-beta.2

Reproduction link

https://github.com/Loilo/vue-loader-15-include-repro

Steps to reproduce

Clone the repository and install npm dependencies:

git clone https://github.com/Loilo/vue-loader-15-include-repro.git
cd vue-loader-15-include-repro
npm install

Run webpack:

npx webpack

What is expected?

The VueLoaderPlugin should initialize correctly.

What is actually happening?

The VueLoaderPlugin complains that "no matching rule for vue files are found".


I've dug into the source and found the cause: The check if a loader is matching foo.vue returns false if the rule has an include property. This is correct for webpack's own behaviour but probably undesirable for vue-loader.

A sufficient solution would probably be to (locally) remove the include property before normalizing rules. I'd be happy to attach a PR for this. I have attached a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants