Skip to content

An option to disable prettier #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmitrybelyakov opened this issue Nov 9, 2018 · 1 comment · Fixed by #1461
Closed

An option to disable prettier #1426

dmitrybelyakov opened this issue Nov 9, 2018 · 1 comment · Fixed by #1461
Assignees
@haoqunjiang
Labels
improvement

Comments

@dmitrybelyakov
Copy link

dmitrybelyakov commented Nov 9, 2018 •
edited
Loading

Version

15.4.0

Reproduction link

https://gist.github.com/dmitrybelyakov/ed64145624f42188372500018671eb0f

Steps to reproduce

Try compiling this component

What is expected?

Compilation time under a second

What is actually happening?

Exponential compilation time increase as HTML elements are nested deeper up to a halt.

There's an issue with prettier: prettier/prettier#1250 & prettier/prettier#4672

Can we please have a config option to disable usage of this library? It has some serious exponential build time degradation as html and components are deeper nested.
haoqunjiang added a commit to haoqunjiang/vue-loader that referenced this issue Jan 4, 2019
@haoqunjiang
feat: add prettify option
539c91b 
closes vuejs#1426
@haoqunjiang haoqunjiang mentioned this issue Jan 4, 2019
Merged
haoqunjiang added a commit that referenced this issue Jan 4, 2019
@haoqunjiang
feat: add prettify option (#1461)
62a9155 
* fix: fix duplicate object key in package.json

* chore: update deps

* feat: add `prettify` option

closes #1426
@dmitrybelyakov
Copy link
Author

@sodatea sweet! thanks a lot!

siphomateke added a commit to siphomateke/zra-helper that referenced this issue Apr 24, 2019
@siphomateke
Fix slow compile with deeply nested HTML
828a96e 
vue-loader uses prettier which has a bug when compiling deeply nested code. Disabling prettier in vue-loader fixes the problem for now.

See vuejs/vue-loader#1426
siphomateke added a commit to siphomateke/zra-helper that referenced this issue Apr 24, 2019
@siphomateke
Fix slow compile with deeply nested HTML
326276d 
vue-loader uses prettier which has a bug when compiling deeply nested code. Disabling prettier in vue-loader fixes the problem for now.

See vuejs/vue-loader#1426
@razbakov razbakov mentioned this issue Dec 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haoqunjiang haoqunjiang

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add prettify option haoqunjiang/vue-loader
2 participants
@dmitrybelyakov @haoqunjiang