Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable auto-loading PostCSS config file #654

Closed
egoist opened this issue Feb 18, 2017 · 1 comment · Fixed by #1055
Closed

Disable auto-loading PostCSS config file #654

egoist opened this issue Feb 18, 2017 · 1 comment · Fixed by #1055
Labels
improvement

Comments

@egoist
Copy link

egoist commented Feb 18, 2017

Since postcss-loader does not load it when option is set. https://github.com/postcss/postcss-loader/blob/master/index.js#L67
@michael-ciniawsky
Copy link

michael-ciniawsky commented Feb 18, 2017 •
edited
Loading

@egoist I work on a PR already including a few other smaller improvements and yes I would also change it to that logic. inline ? use(inline) : use('postcss.config.js') // inline = webpack.config.js. So it's either explicit via webpack.config.js or implicit via postcss.config.js, but clearly separated.

@barraponto barraponto mentioned this issue Jul 1, 2017
Closed
blake-newman added a commit to blake-newman/vue-loader that referenced this issue Nov 12, 2017
@blake-newman
Feature: postcss extensions to default loader if no loader provided
21fc1f9 
If no postcss loader is provided in vue loader options then default to
vue-loader handling

This allows you to use vue internal postcss/css handling with known
postcss extensions

fixes: vuejs#942
fixes: vuejs#800
fixes: vuejs#654
@blake-newman blake-newman mentioned this issue Nov 12, 2017
Merged
yyx990803 pushed a commit that referenced this issue Dec 15, 2017
@blake-newman @yyx990803
feat: normalize default loader for commonly known postcss langs (#1055)
81a59ba 
If no postcss loader is provided in vue loader options then default to
vue-loader handling

This allows you to use vue internal postcss/css handling with known
postcss extensions

fixes: #942
fixes: #800
fixes: #654
@dependencies dependencies bot mentioned this issue Dec 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: Handle postcss file extensions if no loader options give blake-newman/vue-loader
3 participants
@kazupon @michael-ciniawsky @egoist