Dont add postcss loader gratuitously #937
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has not configured any special options for postcss within vue loader and has not added any special query params within the lang attribute (i.e. they just declared <style lang="postcss">) then they probably just wanted syntax highlighting, because postcss is already being run on theystyles.
In PostCSS 6 and the latest postcss-loader you get a warning message for not having sourceMaps options for postcss. If you simply enable sourceMaps within your postcss.config.js and don't add lang="postcss" to your style tag, the warning goes away and sourceMaps works. However, doing this results in losing syntax highlighting for your postcss specific syntax. I looked into vue loader and it looks like if all you want is syntax highlighting and postcss is already being run on the styles anyways, then by not adding postcss loader to the raw loader string you can avoid sourceMaps warnings.
This could also be a change for vue syntax highlighting projects. Perhaps as a community syntax highlighters should offfer another attribute that can be used to declare what syntax highlighting to show that isnt directly tied to what webpack loader should get run