-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detached DOM nodes not deleted after changing page #1319
Comments
I come for this too! |
I can't reproduce any leaks with your fiddle - having detached nodes in memory doesn't mean there's a leak. If you take more snapshots as you switch between the routes, you will notice that every heap snapshot has the same size, and if you compare the snapshots you will see that while there are detached nodes in memory, they are in fact collected in the next snapshot. |
@yyx990803 Thanks for your answer. Ive updated the fiddle with one more page (/baz): |
Version
2.4.0
Reproduction link
http://jsfiddle.net/3xu0o52g/5/embedded/result/
Steps to reproduce
On the JSFiddle
this is what you should get http://imgur.com/Zz1LDY6
this is what you should get http://imgur.com/5bVLudr
our 80 DOM nodes are still in memory
What is expected?
Detached DOM nodes from previous pages should be removed from memory when changing page
What is actually happening?
Detached DOM nodes from previous pages are kept in memory, and make the app unusable in case of multiple list of 100 items made of multiple DOM nodes
The full JSFiddle is here : https://jsfiddle.net/3xu0o52g/5/
I ran into this bug displaying multiple galleries (on different pages) "masonry like" of 100 images.
I really hope it's not the expected behavior, because it makes my app unusable after a few pages.
The text was updated successfully, but these errors were encountered: