-
-
Notifications
You must be signed in to change notification settings - Fork 5k
Doc EN : props vs "props" in passing-props for better comprehension.
#1597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b44dd98
Remove unnecessary new line
MachinisteWeb 5cfc288
Merge remote-tracking branch 'upstream/dev' into dev
MachinisteWeb ca0d38a
Update dev
MachinisteWeb 402e529
Merge remote-tracking branch 'upstream/dev' into dev
MachinisteWeb a949c85
Merge remote-tracking branch 'upstream/dev' into dev
MachinisteWeb e2ac3a7
Use coerce word in replacement of cast.
MachinisteWeb 51b1193
Update passing-props.md
posva File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can coerce to other values, but here we still want to keep cast
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tl;dr => It's ok to merge like that for me :)
But
I'm not sure to well understand difference between « cast » and « coerce » :D
For me, « cast » is the action to explicitly convert a type value into another with some keyword usage.
And « coerce » is the action to implicitly convert a type value with the usage of a context or operand.
You means « with the usage of operand » is not "coercing" but is "casting" too? Even the conversion is « implicite » (no « int » or « string » keyword for example)?
Or I not understand the action behind « This allows you to cast the parameter to another type ».
So in JavaScript you coerce, in C# you cast (same for TypeScript no?)