Add AsyncComponent type to RouteOptions.component

[kaleb]

AsyncComponent is currently allowed, but typescript is giving me a bogus error. This type definition update fixes this.

[posva]

@ktsn Is it worth to add a test for this?

[ktsn]

@posva Yeah, a test would be helpful.

[posva]

hey @kaleb could you add a test for this, please?

[kaleb]

Sure thing.

…

On Tue, Aug 22, 2017, 06:30 Eduardo San Martin Morote < ***@***.***> wrote: hey @kaleb <https://github.com/kaleb> could you add a test for this, please? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1619 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAekZP1lHDbH7zTS3Puxd_KSrsVHwzl4ks5saq3YgaJpZM4Oc7hS> .

[JounQin]

I tried to add this code manually but TypeScript still throws error when using

new VueRouter({
  routes: [
    {
      path: '/',
      component: () => import('../views/Home.vue')
    }
  ]
})

@kaleb Have you used dynamic import for AsyncComponent successfully before?

[kaleb]

@JounQin Yes... sorry, it has taken me a bit to get back to this. Just a minute, and I can look it up where I use it.

[kaleb]

@JounQin https://vuejs.org/v2/guide/components.html#Async-Components

[kaleb]

@JounQin You need to be using webpack for that specific syntax... I myself use SystemJS.

[kaleb]

@posva Added test

[posva]

halp @ktsn 🙏

[JounQin]

@kaleb Of course I'm using dynamic import with webpack.
That's because dynamic import will resolve with default key.

https://github.com/JounQin/ts-study/blob/dynamic_import/src/router/index.ts

So maybe type of AsyncComponent or AsyncComponent as RouterComponent should be updated.

[ktsn]

Oh, I see. I think we should update AsyncComponent type in core because resolving default is the core feature.
This PR looks good to merge for me.

[JoweiBlog]

[ktsn]

The PR was already made. vuejs/vue#6477