Skip to content

refactor(scroll-behavior): clean up scroll-behavior tests #3200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
posva merged 3 commits into from
May 16, 2020
Merged

refactor(scroll-behavior): clean up scroll-behavior tests #3200

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10af614
refactor(scroll-behavior): clean up scroll-behavior tests
Calvin-LL May 14, 2020
cc2f09c
Update test/e2e/specs/scroll-behavior.js
posva May 16, 2020
f0ea11f
Update test/e2e/specs/scroll-behavior.js
posva May 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions test/e2e/specs/scroll-behavior.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,8 @@ module.exports = {
null,
'restore scroll position on back'
)

// with manual scroll restoration
// https://developers.google.com/web/updates/2015/09/history-api-scroll-restoration
.execute(function () {
window.scrollTo(0, 100)
history.scrollRestoration = 'manual'
})
.click('li:nth-child(2) a')
.waitForElementPresent('.view.foo', TIMEOUT)
Expand Down Expand Up @@ -107,19 +103,15 @@ module.exports = {
'scroll to anchor'
)

.execute(function () {
document.querySelector('li:nth-child(5) a').click()
})
.click('li:nth-child(5) a')
.assert.evaluate(
function () {
return document.getElementById('anchor2').getBoundingClientRect().top < 101
},
null,
'scroll to anchor with offset'
)
.execute(function () {
document.querySelector('li:nth-child(6) a').click()
})
.click('li:nth-child(6) a')
.assert.evaluate(
function () {
return document.getElementById('1number').getBoundingClientRect().top < 1
Expand Down