Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

css-loader 4.x.x support? #46

Closed
Sombian opened this issue Aug 1, 2020 · 8 comments · Fixed by #47
Closed

css-loader 4.x.x support? #46

Sombian opened this issue Aug 1, 2020 · 8 comments · Fixed by #47

Comments

@Sombian
Copy link

Sombian commented Aug 1, 2020 •
edited
Loading

vue-loader stopped working after upgrade css-loader to 4.x.x from 3.6.0.
i see some breaking changes documented on css-loader repo.
please fix this.
@huangkaiqiao
Copy link

huangkaiqiao commented Aug 4, 2020 •
edited
Loading

I have encountered the same problem as you do.
i can't find out what's wrong with webpack.config.js of my project
until open this issue.
plz fix this. or change official document of vue-loader.
thanks a lot.

@foxxyz
Copy link

foxxyz commented Aug 7, 2020 •
edited
Loading

@huangkaiqiao for most purposes you can safely swap out vue-style-loader with style-loader and your project should work fine. Also see #42

I will look into what exactly is causing the problem...

Edit: the problem is that css-loader's esModule option is set to true by default in v4. The correct workaround for now is replacing the css-loader declaration in your webpack config with:

{
    loader: 'css-loader',
    options: {
        esModule: false
    }
}

@foxxyz foxxyz mentioned this issue Aug 7, 2020
Closed
@nofacer
Copy link

nofacer commented Aug 9, 2020

@foxxyz works for me. Thanks a lot.

Awea added a commit to wearemd/spa-starter that referenced this issue Aug 10, 2020
@Awea
🔧 Update css-loader configuration to works with v4
13bacfe 
related issue: vuejs/vue-style-loader#46
@IAmJulianAcosta
Copy link

Confirmed, @foxxyz solution worked

@gluons gluons mentioned this issue Aug 15, 2020
Closed
gluons added a commit to gluons/vue-dev-server that referenced this issue Aug 15, 2020
@gluons
👽 Fix style won't load due to vue-style-loader & css-loader v4 co…
6814d51 
…mpatibility

See vuejs/vue-style-loader#46
@foxxyz foxxyz mentioned this issue Aug 16, 2020
Merged
@gotoeveryone gotoeveryone mentioned this issue Sep 5, 2020
Merged
@privatenumber
Copy link

Minimal reproduction repo for reference: https://github.com/privatenumber/vue-css-loader-bug

@privatenumber privatenumber mentioned this issue Sep 20, 2020
Closed
deot added a commit to wya-team/vue-env that referenced this issue Sep 22, 2020
@deot
fix(cli): css-loader@4.x -> 3.x
23153b3 
vuejs/vue-style-loader#46
@ParkYoungWoong ParkYoungWoong mentioned this issue Oct 29, 2020
Closed
@cjblomqvist cjblomqvist mentioned this issue Nov 3, 2020
Closed
@ccnixon
Copy link

ccnixon commented Nov 5, 2020

I was stuck on this issue for days. @foxxyz solution worked for me.

@brophdawg11 brophdawg11 mentioned this issue Nov 9, 2020
Merged
@asika32764 asika32764 mentioned this issue Nov 14, 2020
Open
@beaniejoy beaniejoy mentioned this issue Nov 20, 2020
Open
@IlCallo IlCallo mentioned this issue Nov 30, 2020
Closed
36 tasks
gera2ld added a commit to gera2ld/plaid that referenced this issue Dec 10, 2020
@gera2ld
fix: drop vue-style-loader because it does not support latest css-loader
f82ca02 
Ref: vuejs/vue-style-loader#46
@nolimitdev nolimitdev mentioned this issue Dec 12, 2020
Closed
@joaohaas joaohaas mentioned this issue Jan 5, 2021
Closed
@Otto-J
Copy link

Otto-J commented Feb 22, 2021

耗费了好久时间来排查这个问题。希望更新文档

@p2yang
Copy link

p2yang commented Mar 3, 2021

Thanks. It's ok to use style-loader@2 to replace vue-style-loader.

@Winggo Winggo mentioned this issue May 18, 2021
Merged
mrfinch added a commit to codecombat/codecombat that referenced this issue Mar 8, 2022
@mrfinch
1. change logic of compile-static-templates to remove undefined being…
a116b31 
… added as key in chunkPaths

2.add css-extraction for .css files. This extracts css from vue files and fixes issue caused by css-loader update mentioned here: vuejs/vue-style-loader#46 (comment)
@mrfinch mrfinch mentioned this issue Mar 8, 2022
Merged
mrfinch added a commit to codecombat/codecombat that referenced this issue Mar 8, 2022
@mrfinch
webpack fix (#6549)
79c5207 
* Revert "Revert "upgrade to node 14 and webpack 5 (#6547)""

This reverts commit 54136df.

* 1. change logic of compile-static-templates to remove undefined being added as key in chunkPaths
2.add css-extraction for .css files. This extracts css from vue files and fixes issue caused by css-loader update mentioned here: vuejs/vue-style-loader#46 (comment)
nwinter pushed a commit to codecombat/codecombat that referenced this issue Apr 22, 2022
@mrfinch
webpack fix (#6549)
48c608f 
* Revert "Revert "upgrade to node 14 and webpack 5 (#6547)""

This reverts commit 54136df.

* 1. change logic of compile-static-templates to remove undefined being added as key in chunkPaths
2.add css-extraction for .css files. This extracts css from vue files and fixes issue caused by css-loader update mentioned here: vuejs/vue-style-loader#46 (comment)
nwinter pushed a commit to codecombat/codecombat that referenced this issue Apr 22, 2022
@mrfinch
upgrade to node 14 and webpack 5 (#808)
1ffa48d 
* upgrade to node 14 and webpack 5

* 1. change logic of compile-static-templates to remove undefined being added as key in chunkPaths
    2.add css-extraction for .css files. This extracts css from vue files and fixes issue caused by css-loader update mentioned here: vuejs/vue-style-loader#46 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
9 participants
@privatenumber @IAmJulianAcosta @foxxyz @nofacer @Otto-J @ccnixon @p2yang @huangkaiqiao @Sombian