fix: handle textarea correctly in setValue() and setChecked() (#771)

vuejs · Jun 29, 2018 · 4c9fe3c · 4c9fe3c
1 parent 71a2ac4
commit 4c9fe3c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/packages/test-utils/src/wrapper.js b/packages/test-utils/src/wrapper.js
@@ -748,7 +748,7 @@ export default class Wrapper implements BaseWrapper {
  this.trigger('change')
  }
  }
- } else if (tagName === 'INPUT' || tagName === 'textarea') {
+ } else if (tagName === 'INPUT' || tagName === 'TEXTAREA') {
  throwError(
  `wrapper.setChecked() cannot be called on "text" ` +
  `inputs. Use wrapper.setValue() instead`
@@ -795,7 +795,7 @@ export default class Wrapper implements BaseWrapper {
  `type="radio" /> element. Use wrapper.setChecked() ` +
  `instead`
  )
- } else if (tagName === 'INPUT' || tagName === 'textarea') {
+ } else if (tagName === 'INPUT' || tagName === 'TEXTAREA') {
  throwError(
  `wrapper.setSelected() cannot be called on "text" ` +
  `inputs. Use wrapper.setValue() instead`

diff --git a/test/specs/wrapper/setChecked.spec.js b/test/specs/wrapper/setChecked.spec.js
@@ -93,6 +93,7 @@ describeWithShallowAndMount('setChecked', mountingMethod => {
  const message =
  'wrapper.setChecked() cannot be called on "text" inputs. Use wrapper.setValue() instead'
  shouldThrowErrorOnElement('input[type="text"]', message)
+ shouldThrowErrorOnElement('textarea', message)
  })
 
  it('throws error if element is not valid', () => {

diff --git a/test/specs/wrapper/setSelected.spec.js b/test/specs/wrapper/setSelected.spec.js
@@ -49,6 +49,7 @@ describeWithShallowAndMount('setSelected', mountingMethod => {
  const message =
  'wrapper.setSelected() cannot be called on "text" inputs. Use wrapper.setValue() instead'
  shouldThrowErrorOnElement('input[type="text"]', message)
+ shouldThrowErrorOnElement('textarea', message)
  })
 
  it('throws error if element is not valid', () => {