Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix tagName in setValue() and setChecked() #771

Merged
merged 2 commits into from
Jun 29, 2018
Merged

fix: fix tagName in setValue() and setChecked() #771

merged 2 commits into from
Jun 29, 2018

Conversation

38elements
Copy link
Contributor

This fixes tagName in setSelected() and setChecked().

eddyerburgh
eddyerburgh requested changes Jun 28, 2018
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add tests as well

@38elements
Copy link
Contributor Author

Thank you for pointing out.
I added tests.

@38elements 38elements changed the title fix: fix tagName fix: fix tagName in setValue() and setChecked() Jun 28, 2018
eddyerburgh
eddyerburgh approved these changes Jun 29, 2018
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@eddyerburgh eddyerburgh merged commit 4c9fe3c into vuejs:dev Jun 29, 2018
@38elements 38elements deleted the textarea branch June 29, 2018 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@38elements @eddyerburgh