-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exceptions handled in custom errorHandler are logged to console.error #1760
Closed
marcgibbons opened this issue
Jan 6, 2021
· 0 comments
· Fixed by #1761, eddieferrer/sizesquirrel-open#212 or nextcloud/social#1222
Closed
Exceptions handled in custom errorHandler are logged to console.error #1760
marcgibbons opened this issue
Jan 6, 2021
· 0 comments
· Fixed by #1761, eddieferrer/sizesquirrel-open#212 or nextcloud/social#1222
Labels
Comments
marcgibbons
added a commit
to marcgibbons/vue-test-utils
that referenced
this issue
Jan 6, 2021
When an exception is handled in an `errorHandler` function, do not re-raise it. fix vuejs#1760
13 tasks
lmiller1990
pushed a commit
that referenced
this issue
Jan 10, 2021
When an exception is handled in an `errorHandler` function, do not re-raise it. fix #1760
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Subject of the issue
Exceptions that are caught and handled in an
errorHandler
are re-thrown and logged to console.error.vue-test-utils/packages/test-utils/src/error.js
Lines 27 to 31 in a821908
Steps to reproduce
Expected behaviour
Actual behaviour
Output:
Possible Solution
Update the behaviour of
vue-test-utils
to match Vue's.VueJS will log errors to console if:
errorHandler
is defined; orerrorHandler
Errors will not be logged if a defined
errorHandler
returns without throwing an exception.https://github.com/vuejs/vue/blob/b51430f598b354ed60851bb62885539bd25de3d8/src/core/util/error.js#L58-L71
The text was updated successfully, but these errors were encountered: