Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass refs to functional component stubs #1293

Merged
merged 1 commit into from
Jan 3, 2020
Merged

fix: pass refs to functional component stubs #1293

merged 1 commit into from
Jan 3, 2020

Conversation

xanf
Copy link
Contributor

@xanf xanf commented Aug 14, 2019

Fixes #1292

@JessicaSachs
Copy link
Collaborator

This looks great. Thanks for the additional tests to cover this. I don't see any blockers to merging.

@lmiller1990 lmiller1990 self-requested a review January 3, 2020 08:03
lmiller1990
lmiller1990 approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Simple fix is a good fix.

@lmiller1990 lmiller1990 merged commit d291171 into vuejs:dev Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmiller1990 lmiller1990 lmiller1990 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shallowMount does not correctly pass refs for functional components
3 participants
@xanf @JessicaSachs @lmiller1990