Support for classes inspection #141
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has an implementation for #139 . I based the structure on the existing
html
andtext
methods that only work on a single instance, not an array.Classes has a few tricky edge cases with CSS Modules. I don't use them in my own projects, so I don't have expertise on the right expected behavior, and couldn't find an official inverse function for them. With a CSS Module class that composes another class, both classes end up on the output. Right now, I'm returning both the extension and base classes back, but I don't know if this is the expected behavior. I'm also assuming that the base will always be defined in
$style
, but I haven't experience more exotic examples of CSS Modules (ie extending globals, etc).