build(rollup): upgrade rollup from 1.x to 2.x #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, conflicts. I guess we will review/merge these one by one to avoid this problem. thank you! |
AtofStryker
force-pushed
the
upgrade_rollup
branch
from
6cd888f
to
5d1dc4d
Compare
|
@lmiller1990 glad to help! I have a feeling the |
upgrade rollup and susequent dependencies from 1.x to 2.x
AtofStryker
force-pushed
the
upgrade_rollup
branch
from
5d1dc4d
to
742daeb
Compare
|
@lmiller1990 another rebase 😆 |
|
Seems legit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade rollup and susequent dependencies from 1.x to 2.x
Previously discussed in #1629 (comment). To summarize:
The upgrade from Rollup 1.x to 2.x isn't super involved and is handled in this PR
A gist of the bundle diff is available for the team/community review. None of the semver or acorn variables are actually used in the current bundle, and the other changes can be explained by https://github.com/rollup/plugins/blame/master/packages/commonjs/src/helpers.js#L38 and https://github.com/rollup/plugins/blob/master/packages/commonjs/src/helpers.js#L58 / rollup/plugins#206.
Even though a regression is unlikely, we should test the build and check for regressions, and I would recommend a minor release just in the rare case we would need to patch.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch.fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: