Set _error on vm before we rethrow it in error handler in order to ca… #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch instances where global error handler will log instead of throw
Austio
force-pushed
the
as-error-propagation-patch
branch
from
ec4c18e to
4ba2aa5
Compare
eddyerburgh
approved these changes
Nov 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tch instances where global error handler will log instead of throw
Patches mount to throw if vm._error is set. Handles cases where we are not inBrowser and console is defined.
https://github.com/vuejs/vue/blob/015a31890250e93564959de97372be7bd6195f62/dist/vue.js#L1682-L1703
Follow up to #154