Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: element, vnode, vm, and options are read-only #748

Merged
merged 2 commits into from
Jun 23, 2018

Conversation

38elements
Copy link
Contributor

@38elements 38elements commented Jun 23, 2018

Since vm, element and options are read-only in the type definition, this changes them to read-only.
Since the element property is read-only, this removes unnecessary checks.
This is related to #725.

}
const freezedOptions = Object.freeze(options)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please changed freezedOptions to frozenOptions

Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks fine. One minor change of a variable named (freezed is non-standard English). Otherwise I'm happy to merge

@38elements
Copy link
Contributor Author

Thank you for pointing out.
I changed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants