Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(runtime-vapor): template fragment #100

Merged
merged 8 commits into from
Jan 29, 2024

Conversation

LittleSound
Copy link
Member

The existing template runtime function has some issues when using the DocumentFragment API. This PR aims to solve these problems through refactoring.

related info:whatwg/dom#736

Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 8ef4013
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/65b806c1eb85140008ee88e2
😎 Deploy Preview https://deploy-preview-100--vapor-repl.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 29, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 79.7 kB 28 kB 24.6 kB
compiler-vapor.global.prod.js 43.5 kB 14.5 kB 13.2 kB
runtime-dom.global.prod.js 91.1 kB 34.7 kB 31.2 kB
runtime-vapor.global.prod.js 29.2 kB (-294 B) 11.4 kB (-32 B) 10.4 kB (-29 B)
vue-vapor.global.prod.js 70.4 kB (-294 B) 24.6 kB (-14 B) 22.3 kB (+3 B)
vue.global.prod.js 148 kB 53.9 kB 48 kB

Usages

Name Size Gzip Brotli
createApp 51.4 kB 20 kB 18.3 kB
createSSRApp 54.7 kB 21.3 kB 19.4 kB
defineCustomElement 53.7 kB 20.8 kB 19 kB
vapor 29.4 kB (-294 B) 11.4 kB (-28 B) 10.5 kB (-32 B)
overall 65.1 kB 25.1 kB 22.7 kB

@LittleSound LittleSound marked this pull request as ready for review January 29, 2024 13:54
@sxzz sxzz merged commit 489f11a into main Jan 29, 2024
9 checks passed
@sxzz sxzz deleted the refactor/runtime-vapor-template-fragment branch January 29, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants