Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(runtime-vapor): setStyle reuse from runtime-dom #295

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LittleSound
Copy link
Member

No description provided.

Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit cc3d3a6
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/674c2c107abdd30008212ccc
😎 Deploy Preview https://deploy-preview-295--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 29, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit cc3d3a6
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/674c2c1045d9620008c76121
😎 Deploy Preview https://deploy-preview-295--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LittleSound LittleSound mentioned this pull request Nov 29, 2024
19 tasks
Copy link

github-actions bot commented Nov 29, 2024

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 81 kB 28.4 kB 25.1 kB
runtime-dom.global.prod.js 100 kB (+16 B) 38 kB (+5 B) 34.2 kB (+6 B)
runtime-vapor.global.prod.js 48 kB (+2 B) 18.1 kB (-2 B) 16.6 kB
vue-vapor.global.prod.js 48 kB (-2 B) 18.1 kB (+2 B) 16.6 kB (-2 B)
vue.global.prod.js 158 kB (+16 B) 57.8 kB (+5 B) 51.5 kB (+39 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.4 kB (+2 B) 18.4 kB 16.8 kB (+3 B)
createApp 55.5 kB (+2 B) 21.4 kB 19.5 kB (+5 B)
createVaporApp 27.9 kB (+2 B) 10.6 kB (+3 B) 9.77 kB (+17 B)
createSSRApp 59.5 kB (+2 B) 23.1 kB (+1 B) 21 kB (-4 B)
defineCustomElement 60.3 kB (+2 B) 23 kB (+1 B) 20.9 kB (+6 B)
overall 69.3 kB (+2 B) 26.5 kB 24.1 kB (+16 B)

Copy link
Member

@yyx990803 yyx990803 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since runtime-vapor directly depends on runtime-dom, we can export these directly from runtime-dom instead of moving them to runtime-shared.

Thinking along this line, I'm actually not sure about the necessity of runtime-shared.

@LittleSound
Copy link
Member Author

LittleSound commented Nov 30, 2024

Since runtime-vapor directly depends on runtime-dom

it should be an error caused by negligence.

@yyx990803
Copy link
Member

My bad, I was looking at compiler-vapor, not runtime-vapor. Discussed with @edison1105 yesterday and I think we need a bit of restructure:

  1. The @vue/vapor package is unnecessary. vue should directly depend on @vue/runtime-vapor (content of current @vue/vapor should be moved to vue/vapor).

  2. The @vue/runtime-shared package is unnecessary. @vue/runtime-vapor should list @vue/runtime-dom as a peer dep so it can import shared utils from runtime-dom directly.

  3. Similarly, @vue/compiler-vapor should rely on @vue/compiler-dom as a peer dep instead of direct dep.

Copy link

pkg-pr-new bot commented Dec 1, 2024

Open in Stackblitzplayground

@vue/compiler-core

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-core@295

@vue/compiler-dom

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-dom@295

@vue/compiler-ssr

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-ssr@295

@vue/compiler-vapor

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-vapor@295

@vue/compiler-sfc

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-sfc@295

@vue/reactivity

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/reactivity@295

@vue/runtime-core

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-core@295

@vue/runtime-dom

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-dom@295

@vue/runtime-shared

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-shared@295

@vue/runtime-vapor

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-vapor@295

@vue/server-renderer

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/server-renderer@295

@vue/shared

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/shared@295

vue

npm i https://pkg.pr.new/vuejs/vue-vapor/vue@295

@vue/compat

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/compat@295

@vue/vapor

npm i https://pkg.pr.new/vuejs/vue-vapor/@vue/vapor@295

commit: cc3d3a6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants