This repository was archived by the owner on Jul 19, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The design of the components has not yet been discussed. We have to put this PR on hold. |
sxzz
reviewed
Nov 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. However, we have to wait until the team discusses component design.
One of the goals is to simplify the current complexity. Maybe we have to explore it in mainline (Vue Core) first...
Ok, that’s fine. I’ll wait for further updates! (I can't get to sleep because of…) |
Size ReportBundles
Usages
|
sxzz
reviewed
Nov 28, 2023
sxzz
approved these changes
Nov 29, 2023
Closed
I get an error |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #4
I have implemented some foundational aspects of components.
I've made changes to manage
setup~render execution, which was on the playground side in the existing implementation, and effectScope, which was a local variable in the render function, as component instances.These instances are planned to be implemented in the future to register lifecycle hooks and manage provides, similar to traditional components.
Also, regarding the setup and render options, they are treated only as compile outputs this time and were not intended to be public for users, so I have named them InternalOption.
Please let me know if these APIs (Options) were supposed to be treated as public, and I will make the necessary adjustments.
@vue/*
orvue
?