Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prop validator fails to generate validation error message when using Symbols #10519

Closed
thomasleveil opened this issue Sep 15, 2019 · 2 comments · Fixed by #10529
Closed

prop validator fails to generate validation error message when using Symbols #10519

thomasleveil opened this issue Sep 15, 2019 · 2 comments · Fixed by #10529
Labels
bug has PR

Comments

@thomasleveil
Copy link

thomasleveil commented Sep 15, 2019 •
edited
Loading

Version

2.6.10

Reproduction link

https://jsfiddle.net/zs5dan7x/

Steps to reproduce

  • pass a Symbol as the value of a component prop which expects another type

What is expected?

the console should show the validation error message

What is actually happening?

the prop validator tries to build an validation error message, it fails with :

TypeError: Cannot convert a Symbol value to a string
posva added a commit that referenced this issue Sep 17, 2019
@posva
fix(props): correctly warn when a provided prop is Symbol
b52883c 
Fixes #10519
@posva posva mentioned this issue Sep 17, 2019
Merged
13 tasks
@posva
Copy link
Member

posva commented Sep 17, 2019

Marked as a bug because it crashes the application

@amumubuku
Copy link

Symbol('bad').toString()

posva added a commit that referenced this issue Sep 21, 2020
@posva
fix(props): correctly warn when a provided prop is Symbol (#10529)
abb5ef3 
* fix(props): correctly warn when a provided prop is Symbol

Fixes #10519

* style: space before parens
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug has PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(props): correctly warn when a provided prop is Symbol vuejs/vue
3 participants
@thomasleveil @posva @amumubuku