Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing e2e test on chrome due to fault in spec #7937

Closed
TimSpeelman opened this issue Mar 31, 2018 · 2 comments
Closed

Failing e2e test on chrome due to fault in spec #7937

TimSpeelman opened this issue Mar 31, 2018 · 2 comments
Labels

Comments

@TimSpeelman
Copy link
Contributor

Version

2.5.17-beta.0

Reproduction link

https://jsfiddle.net/tox8hg2h/1/

Steps to reproduce

On a clean install of the dev branch run npm run test:e2e.

What is expected?

All tests should pass.

What is actually happening?

A test fails at test\e2e\specs\todomvc.js:124:15, returning:
Testing if element <.todo:nth-child(1) label> contains text: "edited!". - expected "edited!" but got: "test"


The todomvc.js spec double clicks the label of an already-completed todo (line 117), then changes its text (lines 120-121) and finally blurs the field by clicking something else (line 122): the footer. But here's the catch: it actually "clicks the in-view centre point" of the footer (according to Nightwatch docs), which is where the 'Active' filter button is rendered (at least when using Chrome, this does not happen in PhantomJS).

As it clicks the 'Active' filter, the just-edited todo is hidden. When the spec then asserts the text of the first visible todo, it does not match its expectations and fails. So the fault lives on line 122: browser.click('footer').

A simple solution is simply to click something else, like the '.new-todo' text input. This solves the issue. I will make a PR to fix this.

@TimSpeelman
Copy link
Contributor Author

As promised: #7938

I was looking at options for moving e2e tests to Chrome headless. This was the only test failing on Chrome headless, hence my fix. Is there anything else holding Vue back from this move?

@yyx990803
Copy link
Member

closed via #7938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants