-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSR: style binding keeps falsy values #9231
Labels
Comments
1 task
yyx990803
added a commit
that referenced
this issue
Jan 11, 2019
Ignores values that are not string or numbers, and append px as default unit to appropriate properties. There will still be certain cases where the user simply provides an invalid string value to a property which will be too costly to detect (it's possible by using the `cssstyle` package, but very heavy). But in such cases the user would already notice the style is not working on the client, so it's not really worth it for the perf implications. fix #9231
Closed via 7d9cfeb |
f2009
pushed a commit
to f2009/vue
that referenced
this issue
Jan 25, 2019
Ignores values that are not string or numbers, and append px as default unit to appropriate properties. There will still be certain cases where the user simply provides an invalid string value to a property which will be too costly to detect (it's possible by using the `cssstyle` package, but very heavy). But in such cases the user would already notice the style is not working on the client, so it's not really worth it for the perf implications. fix vuejs#9231
This was referenced Nov 6, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
2.5.21
Reproduction link
https://codesandbox.io/s/o95x14r0xz (I know, minimal repro below)
Steps to reproduce
View page source
What is expected?
What is actually happening?
Reproduce in
vue/test/ssr/ssr-string.spec.js
then runnpm run test:ssr
:The text was updated successfully, but these errors were encountered: