-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: New syntax for scoped slots #9306
Comments
I like both the new syntax (shorthand and not) and the new, more intuitive semantics. IMO Will it emit a compilation error if one use |
So, I think for scoped slots syntax must follow the rule: "There should be one - and preferably only one - obvious way to do it". |
@c01nd01r do you use the : and @ shorthands? |
@yyx990803 <AppWrapper class="wrapper"
prop-one="one"
prop-two="two"
()="{ wrap }">
<AppTranslate t="hello" ()="{ text }">
<AppButton @click="wrap.handler">{{ text }}</AppButton>
</AppTranslate>
</AppWrapper> the more components there are, the easier it will be in the markup to lose this shorthands. |
@dimensi so just use the long form |
@yyx990803 Yep, much more often than Anyway, I will be glad if |
My thoughts on the naming/shorthand: ATM I'm not feeling too verbose to use We now only have shorthands for directives (namely So what about use <foo v-scope="foo">
<bar v-scope="bar">
<baz v-scope="baz">
{{ foo }} {{ bar }} {{ baz }}
</baz>
</bar>
</foo> |
If I may suggest a different shorthand
The ampersand is known in programming as a reference/pointer to variables. |
@rellect it's more vue like, than (). Looks nice. <foo &="{ fooText }">
{{ fooText }}
<template &header="{ msg }">
{{ msg }}
</template>
</foo> or <foo &="{ fooText }" &header="{ msg }">
{{ fooText }} - {{ msg }}
<header-block slot="header" :title="msg" />
<bar &="baz" &side-bar="{ sideBarContent }">
{{ baz }}
<side-bar :content="sideBarContent" slot="side-bar" />
</bar>
</foo>
// with slot-props
<foo slot-props="{ fooText }" slot-props.header="{ msg }">
{{ fooText }} - {{ msg }}
<header-block slot="header" :title="msg" />
<bar slot-props="baz" slot-props.side-bar="{ sideBarContent }">
{{ baz }}
<side-bar :content="sideBarContent" slot="side-bar" />
</bar>
</foo> 🤔 upd: <foo ()="{ fooText }">
{{ fooText }}
<template slot="header" ()="{ msg }">
<div>
{{ msg }}
</div>
</template>
</foo> |
How will that new syntax work with v-for like in the documentation or when you have multiple named slot to which you want to pass different variable? When I consider those 2 scenarios the old syntax of declaring the provided variable on the "slot" rather than on the parent component made more sense. |
@Gudradain see usage examples - you'd have to use a |
@rellect @dimensi I think the difference between For named slots yes <foo ()="{ fooText }">
{{ fooText }}
<template (header)="{ msg }">
{{ msg }}
</template>
</foo>
<!-- or -->
<foo &="{ fooText }">
{{ fooText }}
<template &header="{ msg }">
{{ msg }}
</template>
</foo> This can even apply to non scoped slots, effectively unifying <foo>
<div (header)>hello</div>
<div (footer)>bye</div>
</foo>
<!-- or -->
<foo>
<div &header>hello</div>
<div &footer>bye</div>
</foo> |
I was hesitant about the short notation, but when using it to set the slot name it's beginning to grow on me ... ...but as a sidenote it might confuse the hell out of people working on both Angular and Vue Projects - they use |
Yea, i see () syntax in angular, what why i call it not vue like syntax. <foo &="{ fooText }" &header="{ msg }">
{{ fooText }} - {{ msg }}
<header-block slot="header" :title="msg" />
<bar &="baz" &side-bar="{ sideBarContent }">
{{ baz }}
<side-bar :content="sideBarContent" slot="side-bar" />
</bar>
</foo> As I understand it, we want to make the syntax clearer and more understandable, so that it is clear where this or that variable comes from. Pointing at the component itself all the variables from different slots at once, we immediately see what came from + this gives us the opportunity to get for rare cases the ability to mix variables from different scoped slots |
@dimensi yeah I think having all slots declared on component root can be confusing. BTW I moved this to the formal RFC process! vuejs/rfcs#2 - let's continue there. |
This is an update of #9180 where we attempt to finalize a new syntax proposal for scoped slots (in a backwards compatible way).
Rationale
When we first introduced scoped slots, it was verbose because it required always using
<template slot-scope>
:To make it less verbose, in 2.5 we introduced the ability to use
slot-scope
directly on the slot element:This means it works on component as slot as well:
However, the above usage leads to a problem: the placement of
slot-scope
doesn't always clearly reflect which component is actually providing the scope variable. Hereslot-scope
is placed on the<bar>
component, but it's actually defining a scope variable provided by the default slot of<foo>
.This gets worse as the nesting deepens:
It's not immediately clear which component is providing which variable in this template.
Someone suggested that we should allow using
slot-scope
on a component itself to denote its default slot's scope:Unfortunately, this cannot work as it would lead to ambiguity with component nesting:
This is why I now believe allowing using
slot-scope
without a template was a mistake.In 2.6, we are planning to introduce a new syntax for scoped slots.
Goals of the new proposal
Still provide succinct syntax for most common use cases of scoped slots (default slots)
Clearer connection between scoped variable and the component that is providing it.
Syntax Details
Introducing a new special attribute:
slot-props
.It can be used on a component to indicate that the component's default slot is a scoped slot, and that props passed to this slot will be available as the variable declared in its attribute value:
It can also be used on
<template>
slot containers (exactly the same usage asslot-scope
in this case):It can NOT be used on normal elements.
slot-props
also has a shorthand syntax:()
.The above examples using shorthand syntax:
The shorthand is
()
because it resembles the starting parens of an arrow function and loosely relates to "creating a scope". An arrow function is also typically used for render props, the equivalent of scoped slots in JSX.Comparison: New vs. Old
Let's review whether this proposal achieves our goals outlined above:
Still provide succinct syntax for most common use cases of scoped slots (single default slot):
Can we get any more succinct than this?
Clearer connection between scoped variable and the component that is providing it:
Let's take another look at the deep-nesting example using current syntax (
slot-scope
) - notice how slot scope variables provided by<foo>
is declared on<bar>
, and the variable provided by<bar>
is declared on<baz>
...This is the equivalent using the new syntax:
Notice that the scope variable provided by a component is also declared on that component itself. The new syntax shows a clearer connection between slot variable declaration and the component providing the variable.
Here are some more usage examples using both the new and old syntax.
Q&A
Why a new attribute instead of fixing
slot-scope
?If we can go back in time, I would probably change the semantics of
slot-scope
- but:That would be a breaking change now, and that means we will never be able to ship it in 2.x.
Even if we change in in 3.x, changing the semantics of existing syntax can cause a LOT of confusion for future learners that Google into outdated learning materials. We definitely want to avoid that. So, we have to introduce a new attribute to differentiate from
slot-scope
.What happens to
slot-scope
?It's going to be soft-deprecated: it will be marked deprecated in the docs, and we would encourage everyone to use / switch to the new syntax, but we won't bug you with deprecation messages just yet because we know it's not a top priority for everyone to always migrate to the newest stuff.
In 3.0 we do plan to eventually remove
slot-scope
, and only supportslot-props
and its shorthand. We will start emitting deprecation messages forslot-scope
usage in the next 2.x minor release to ease the migration to 3.0.Since this is a pretty well defined syntax change, we can potentially provide a migration tool that can automatically convert your templates to the new syntax.
The text was updated successfully, but these errors were encountered: