Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): Fix missing function type declaration for ref attribute #12763

Open
wants to merge 283 commits into
base: dev
Choose a base branch
from
Open

fix(types): Fix missing function type declaration for ref attribute #12763

wants to merge 283 commits into from

Conversation

dafengxiang
Copy link

@dafengxiang dafengxiang commented Aug 26, 2022 •
edited
Loading

The ref attribute supports incoming strings and functions, but the function type declaration is not provided in the type declaration

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

pikax and others added 30 commits May 4, 2022 22:25
@pikax
Merge pull request vuejs#3 from dwelch2344/move_to_typescript
9949ab5 
WIP: typescript love on the tests
@yyx990803
build: target es5
19a5a35
@yyx990803
chore: remove git add from lint-staged script
de1fd98
@yyx990803
build: ignore dist files for server-renderer and template-compiler
7a8284d
@yyx990803
build: remove flow deps
c19fabd
@yyx990803
chore: fix dev scripts
4d1d0f0
@yyx990803
build: remove deps
0b56077
@yyx990803
build: sort deps again
3421db3
@yyx990803
build: remove stale lockfile
fe13212
@yyx990803
test: migrate tests to vitest (wip)
972d806
@yyx990803
test: first full test suite passing
8e672c4
@yyx990803
test: jasmine.createSpy -> vi.fn
52627b9
@yyx990803
test: remove global before waitForUpdate
63e7d59
@yyx990803
test: shim done interface for tests
5ec77f3
@yyx990803
test: move __WEEX__ flag to runtime for tests
69edc9a
@yyx990803
test: move transition + keep alive test cases
29989a1
@yyx990803
test: unit/features/component passing
250bc17
@yyx990803
test: all directive tests passing
906907f
@yyx990803
test: all features except transition pass
73bcd07
@yyx990803
test: all unit tests except transition passing
fed8c3b
@yyx990803
test: skip transition tests for now
23b1fb5
@yyx990803
types: fix types
23bd3b2
@yyx990803
test: partial ssr tests passing
2d019e4
@yyx990803
refactor: remove weex from codebase
d8c3bbf
@yyx990803
build: separate src and test tsconfig
575f076
@yyx990803
chore: remove stale js file
7136e19
@yyx990803
test: fix ssr test imports
5fb1c9d
@yyx990803
build: externalize stream to avoid warning
c63d43c
@yyx990803
build: restore cjs entry files
3a27b6b
@yyx990803
test: all ssr tests passing
898d1e1
troy351 and others added 29 commits July 19, 2022 23:16
@troy351
chore(sfc): remove useless vue-template-es2015-compiler (vuejs#12677)
135d074
@yyx990803
feat(setup): support listeners on setup context + useListeners() he…
adf3ac8 
…lper

These are added because Vue 2 does not include listeners in
`context.attrs` so there is no way to access the equivalent of
`this.$listeners` in `setup()`.
@yyx990803
types: fix manual api types for useAttrs/useListeners
ce6fc14
@yyx990803
fix(types): avoid circular type inference between v2 and v3 instance …
fabc1cf 
…types

fix vuejs#12683
@edison1105
fix(sfc): align <script setup> component resolution edge case with …
a695c5a 
…v3 (vuejs#12687)

fix vuejs#12685
@danielroe
fix(types): export defineAsyncComponent type (vuejs#12684)
ba7dd2c
@yyx990803
fix(reactivity): fix shallowReactive nested ref setting edge cases
2af751b 
ref vuejs#12688
@yyx990803
release: v2.7.8
1d8b892
@jfparadis-appomni
fix(types): Make SetupBindings optional on ExtendedVue and CombinedVu…
00458cd 
…eInstance (vuejs#12727)

fix vuejs#12726
fix vuejs#12717
@jonaskuske
fix(compiler-sfc): allow full hostnames in asset url base (vuejs#12732)
5c742eb 
fix vuejs#12731
@yyx990803
fix(types): fix options suggestions when using defineComponent
4b37b56 
functional component overloads should be moved last

fix vuejs#12736
@yyx990803
fix: ensure render watcher of manually created instance is correctly …
bd89ce5 
…tracked in owner scope

fix vuejs#12701
@yyx990803
fix(watch): avoid pre watcher firing on unmount
f0057b1 
fix vuejs#12703
@yyx990803
feat(types): export DefineComponent
80d1baf 
close vuejs#12748
@yyx990803
fix(types): allow attaching unknown options to defined component
b4bf4c5 
fix vuejs#12742
@gulewei
feat(types): support mixins inference for new Vue() (vuejs#12737)
89a6b5e 
close vuejs#12730
@linshuohao
fix(compiler-sfc): rewriteDefault for class with decorators (vuejs#12747
5221d4d 
)
@JuniorTour
fix: directives shorthand normalize error (vuejs#12744)
2263948 
fix vuejs#12743
@Justineo
chore: fix some legacy doc urls in warnings and readme (vuejs#12725) …
9eb8ea5 
…[ci skip]
@nooooooom
feat(types): enhance type for onErrorCaptured (vuejs#12735)
bba6b3d
@TheAlexLichter
fix(ssr): fix on-component directives rendering (vuejs#12661)
165a14a 
fix vuejs#10733
@yyx990803
fix: fix effect scope tracking for manually created instances
7161176 
fix vuejs#12705
@yyx990803
fix(types): fix missing error for accessing undefined instance proper…
8521f9d 
…ties

fix vuejs#12718
@yyx990803
release: v2.7.9
1561888
@sandersn
fix(types): Add missing type parameter constraints (vuejs#12754)
810f6d1
@yyx990803
fix(compiler-sfc): avoid deindent when lang is jsx/tsx
46ca7bc 
fix vuejs#12755
@nooooooom
fix: fix parent of multi-nested HOC $el not updating (vuejs#12757)
e0b26c4 
fix vuejs#12589
@yyx990803
release: v2.7.10
ee57d9f
@dafengxiang
fix(types): Fix missing function type declaration for ref attribute
8a7c98f 
The ref attribute supports incoming strings and functions, but the function type declaration is not provided in the type declaration
@shiluo34 shiluo34 mentioned this pull request Sep 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.