Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger when adding new property with Vue.set #12972

Closed
wants to merge 2 commits into from

Conversation

xiaowei-one
Copy link

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@Justineo
Copy link
Member

Justineo commented Feb 28, 2023

Hi, can you describe the problem you are trying to solve here?

Never mind. I found the related issue: #12967

Can you add new test cases for this fix?

@xiaowei-one
Copy link
Author

I have submitted😄

@yyx990803 yyx990803 closed this in 6d857f5 Dec 6, 2023
@yyx990803
Copy link
Member

Thanks for the PR, but there are a few other cases that need to be handled as well. See more comprehensive fix in 6d857f5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants