introduce a warning with misusage binding in dev mode #4084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #4060 (comment) But this is a pretty smart way to detect pure literals ;) |
| } | ||
|
|
||
| try { | ||
| func() |
There was a problem hiding this comment.
While being a savvy technique, this is also very very dangerous. It will introduce code execution, especially if expression is passed from user input or database.
There was a problem hiding this comment.
En, this is just a check in dev mode. If the expression passed down is plain js code like 'alert(1)', it'll be warned.
<component :val="alert(1)"></component>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discused in #4060 , we could introduce a warning in dev mode for v-bind with literal to avoid unnessary rendering.