Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(runtime): correctly render the embed attribute allowfullscreen #6204

Closed
wants to merge 2 commits into from

Conversation

gebilaoxiong
Copy link
Member

#6202

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

correctly render the embed attribute allowfullscreen

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Hanks10100 and others added 2 commits July 24, 2017 07:32
* build(release weex): ignore the file path of entries

* [release] weex-vue-framework@2.4.2-weex.1
@yyx990803
Copy link
Member

FYI, allowfullscreen is indeed a Boolean attribute and in the spec it can only be used on <iframe>. Changing it to enumerable would break its usage on <iframe>.

Flash's usage of allowfullscreen on <embed> is technically not spec compliant. However, this usage seems to be widely adopted so I added a special case in d77b953 .

@yyx990803 yyx990803 closed this Sep 1, 2017
@gebilaoxiong gebilaoxiong deleted the fix-emberd-attr branch October 29, 2017 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants