Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render entities as-is (prevent server-client dom mismatch), fixes #6345 #6371

Closed
wants to merge 3 commits into from
Closed

render entities as-is (prevent server-client dom mismatch), fixes #6345 #6371

wants to merge 3 commits into from

Conversation

buhrmi
Copy link

@buhrmi buhrmi commented Aug 15, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Hanks10100 and others added 3 commits July 24, 2017 07:32
@HerringtonDarkholme
Copy link
Member

I guess the decode is done by intention. Note compiler is shared across ssr, client side template and vue-loader, I wonder if decode is necessary under different situation. However, I'm not familiar enough to give confident answer.

Would you mind digging deeper for this? Thanks!

@yyx990803
Copy link
Member

Thanks for the PR, but the decode in the parser is necessary for correct client-side behavior. The bug was actually introduced by the SSR optimizing compiler in 2.4 and a proper fix is provided in 172dbf9

@yyx990803 yyx990803 closed this Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants